Conversation
casperdcl
force-pushed
the
rattler
branch
17 times, most recently
from
eab54e7 to
d2d2d53
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Hi @casperdcl, should we be concerned about this warning? 
|
|
I deployed the 'build' workflow to run all tests and got a failure related to astra: |
This comment was marked as duplicate.
This comment was marked as duplicate.
lauramurgatroyd
left a comment
lauramurgatroyd
left a comment
There was a problem hiding this comment.
Hi, here are a few things I noticed when I was looking through the code changes
| path: . | ||
|
|
||
| build: | ||
| number: ${{ build_number }} |
There was a problem hiding this comment.
this used to be {{ GIT_DESCRIBE_NUMBER }} - is there a reason for the change to 0?
There was a problem hiding this comment.
not available in rattler unfortunately; though I just opened prefix-dev/rattler-build#2484 lol 🤞
There was a problem hiding this comment.
In the developer meeting we discussed that the latest 'dev' build is number 42. So we should set the build number to 42 or 43
There was a problem hiding this comment.
I thought @gfardell would delete the dev builds while we wait for the next rattler-build release.
| --test dist/*/cil-* --extra-deps numpy=${{ matrix.numpy-version }} | ||
| recipe-path: recipe.yaml | ||
| build-args: --experimental -c conda-forge -c https://software.repos.intel.com/python/conda -c ccpi --variant python=${{ matrix.python-version }} | ||
| artifact-name: conda-py${{ matrix.python-version }}-${{ matrix.os }} |
There was a problem hiding this comment.
Is there a reason why this is now named 'conda' - it used to be named 'cil'?
There was a problem hiding this comment.
- makes it clear that the art[ie]fact is a
condafile in the GitHub UI - makes it easy to copy-paste this code to other libraries we maintain without modification
There was a problem hiding this comment.
I think it would be better to be consistent with the previous naming: https://anaconda.org/channels/ccpi/packages/cil/files
There was a problem hiding this comment.
The conda file names are unchanged. This is just the GitHub art[ie]fact zip name
This comment was marked as resolved.
This comment was marked as resolved.
|
All of the actions are passing at: https://github.com/TomographicImaging/CIL/actions/runs/25727755713 |
|
Hi @casperdcl I am happy with everything else - just added a couple of comments |
2 participants
dxchange,olefile,packaging)conda-build->rattler-build(follow-up to CI: Use conda-build instead of conda mambabuild (boa) #2320, CI: fix conda upload *.conda instead of *.tar.bz2 #2228)conda-> native (since rattler doesn't support--numpy=...)Testing
Note
development instructions are unchanged (still just
conda install --file requirements-test.yml && pip install --no-deps -e .)windowsin this PR branchwindowsis only tested onmaster/tagas before)Checklist